Custom SSL certificate process for Capsules clarification #3940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
|
The PR preview for 825706c is available at theforeman-foreman-documentation-preview-pr-3940.surge.sh The following output files are affected by this PR: |
Lennonka
requested changes
Jun 23, 2025
|
|
||
| [NOTE] | ||
| ==== | ||
| Once you have obtained the server certificate, private key, and CA chain from the Certificate Authority (CA) for each {SmartProxyServer}, organize these files into separate directories named after each {SmartProxyServer} on your {ProjectServer}. |
There was a problem hiding this comment.
Suggested change
| Once you have obtained the server certificate, private key, and CA chain from the Certificate Authority (CA) for each {SmartProxyServer}, organize these files into separate directories named after each {SmartProxyServer} on your {ProjectServer}. | |
| Once you have obtained the server certificate, private key, and CA chain from the Certificate Authority (CA) for each {SmartProxyServer}, organize these files into separate directories on your {ProjectServer}. | |
| Name the directories after each {SmartProxyServer}. |
For better clarity
| ifeval::["{context}" == "{smart-proxy-context}"] | ||
| On {ProjectServer}, create a custom certificate for your {ProductName}. | ||
| If you already have a custom SSL certificate for {ProductName}, skip this procedure. | ||
| On {ProjectServer}, you must generate a unique private key and Certificate Signing Request (CSR) for each {ProductName} that you want to secure with a custom SSL certificate. |
There was a problem hiding this comment.
Suggested change
| On {ProjectServer}, you must generate a unique private key and Certificate Signing Request (CSR) for each {ProductName} that you want to secure with a custom SSL certificate. | |
| On {ProjectServer}, generate a unique private key and Certificate Signing Request (CSR) for each {ProductName} that you want to secure with a custom SSL certificate. |
Remove fluff
Comment on lines
+11
to
+12
|
|
||
| Use this procedure for each {ProductName} that requires a custom SSL certificate. |
There was a problem hiding this comment.
Suggested change
| Use this procedure for each {ProductName} that requires a custom SSL certificate. |
I think that this is an unnecessary repetition.
pr-processor
bot
added
Waiting on contributor
|
triage: @rh-max Please ping someone for tech review & apply Lena's suggestions. |
|
Moving to draft while we look for a new owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Procedure clarifications for SSL certs for Capsules.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-22614
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: