Skip to content

Clarify wording that unlocked templates are not supported #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Clarify wording that unlocked templates are not supported #4280

merged 1 commit into from
Sep 22, 2025

Conversation

sbernhard
Copy link
Contributor

@sbernhard sbernhard commented Sep 19, 2025 •
edited by maximiliankolb
Loading

What changes are you introducing?

Clarifiy which templates are supported etc.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Customer feedback

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

Review checklists

Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):

  • The PR documents a recommended, user-friendly path.
  • The PR removes steps that have been made unnecessary or obsolete.
  • Any steps introduced or updated in the PR have been tested to confirm that they lead to the documented end result.

Style review (by a Technical Writer who did not author the PR):

  • The PR conforms with the team's style guidelines.
  • The PR introduces documentation that describes a user story rather than a product feature.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2025 •
edited
Loading

The PR preview for bf20e01 is available at theforeman-foreman-documentation-preview-pr-4280.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my test on orcharhino nightly, templates are marked as unsupported after unlocking them. This is independent of users changing them.

One suggestion, overall LGTM!

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Sep 19, 2025
@sbernhard sbernhard force-pushed the clarify_supp_templates branch from 5ab42aa to bf20e01 Compare September 19, 2025 11:38
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author Needs re-review labels Sep 19, 2025
maximiliankolb
maximiliankolb approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective style review done No issues from docs style/grammar perspective testing done No issues from the functional perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 19, 2025
@maximiliankolb maximiliankolb merged commit eb8e6e1 into theforeman:master Sep 22, 2025
10 checks passed
@maximiliankolb maximiliankolb deleted the clarify_supp_templates branch September 22, 2025 13:28
maximiliankolb added a commit that referenced this pull request Sep 22, 2025
@sbernhard @maximiliankolb
Clarify wording that unlocked templates are not supported (#4280)
39cd635 
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit eb8e6e1)
@maximiliankolb
Copy link
Contributor

Merged to "master" and cherry-picked:
ebc60ad..39cd635 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective testing done No issues from the functional perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernhard @maximiliankolb