feat(pingcap/tidb): block mergeing for pull requests which have none finished test tasks #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
size/S
|
Tested with regex101.com: link 
|
…finished test tasks Signed-off-by: wuhuizuo <[email protected]>
wuhuizuo
force-pushed
the
feature/add-pr-description-checker-for-test-tasks
branch
from
95197d5 to
5df2dfe
Compare
bb7133
reviewed
Sep 4, 2023
wuhuizuo
commented
Sep 4, 2023
wuhuizuo
commented
Sep 4, 2023
wuhuizuo
commented
Sep 4, 2023
wuhuizuo
commented
Sep 4, 2023
wuhuizuo
commented
Sep 4, 2023
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
deleted the
feature/add-pr-description-checker-for-test-tasks
branch
|
fixed in #959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wuhuizuo [email protected]
What problem does this PR solve?
Problem Summary: blocking merging when pull request has none test tasks checked.
What is changed and how it works?
What's Changed:
pingcap/tidb.do-not-merge/needs-tests-checkedforpingcap/tidb.do-not-merge/needs-tests-checkedlabelHow it Works:
Check pull request description with format check external plugin.