Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 16, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #5454

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 16, 2022
@ti-chi-bot ti-chi-bot requested review from JmPotato and Yisaer August 16, 2022 07:35
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #5435 (8edd5f2) into master (1205326) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 8edd5f2 differs from pull request most recent head ce32127. Consider uploading reports for the commit ce32127 to get more accurate results

@@            Coverage Diff             @@
##           master    #5435      +/-   ##
==========================================
- Coverage   75.56%   75.48%   -0.08%     
==========================================
  Files         319      319              
  Lines       31534    31534              
==========================================
- Hits        23828    23805      -23     
- Misses       5668     5676       +8     
- Partials     2038     2053      +15     
Flag Coverage Δ
unittests 75.48% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/btree/btree.go 86.26% <ø> (-0.97%) ⬇️
pkg/codec/codec.go 90.14% <ø> (ø)
server/cluster/unsafe_recovery_controller.go 80.56% <ø> (-0.36%) ⬇️
server/encryptionkm/key_manager.go 70.11% <ø> (ø)
server/handler.go 52.70% <ø> (ø)
server/join/join.go 59.30% <ø> (ø)
server/schedule/labeler/rules.go 87.50% <ø> (-2.28%) ⬇️
server/schedule/operator/builder.go 86.39% <ø> (ø)
server/schedule/placement/fit.go 90.72% <ø> (ø)
server/statistics/region_collection.go 97.48% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2022
Signed-off-by: nolouch <[email protected]>
@nolouch nolouch marked this pull request as ready for review August 26, 2022 04:03
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Aug 26, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 26, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ce32127

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2022
@ti-chi-bot ti-chi-bot merged commit 2adb979 into tikv:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go to 1.19
5 participants