Skip to content

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 3, 2025

What problem does this PR solve?

Issue Number: ref #9707.

What is changed and how does it work?

This change removes the global `ServerServiceRegistry` and the auto-registration `install` packages for microservices, as they are no longer used.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.79%. Comparing base (9b4433d) to head (d882784).
⚠️ Report is 1 commits behind head on master.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9718      +/-   ##
==========================================
- Coverage   76.79%   76.79%   -0.01%     
==========================================
  Files         483      482       -1     
  Lines       76722    76715       -7     
==========================================
- Hits        58921    58912       -9     
+ Misses      14214    14210       -4     
- Partials     3587     3593       +6     
Flag Coverage Δ
unittests 76.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JmPotato
Copy link
Member Author

JmPotato commented Sep 3, 2025

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2025

@bufferflies: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 4, 2025
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2025
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-03 12:27:14.779511845 +0000 UTC m=+9978.762609292: ☑️ agreed by bufferflies.
  • 2025-09-04 02:59:35.959417885 +0000 UTC m=+62319.942515323: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 9822378 into tikv:master Sep 4, 2025
26 of 28 checks passed
@JmPotato JmPotato deleted the remove_unused_install branch September 4, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants