-
Notifications
You must be signed in to change notification settings - Fork 3.3k
WIP: Real dataset location #26542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: Real dataset location #26542
Conversation
ef97a9e
to
432c5ff
Compare
For JDBC-based connectors this is fine, but there are other connectors with different connection url format. Hive uses To handle these connection URLs differently, there should be at least |
We can add a connector name to |
Sounds reasonable. One more thing though - |
@dolfinus that wouldn't make sense in the context of the lake connectors where you want s3://bucket/table/location |
I mean that these should be separated options. Table location for lake connectors is one of table properties called |
@dolfinus I was expecting the location to be within the table’s domain. I don't understand why we need to involve the catalog perspective |
@chenjian2664 Have you checked the issue #25555? |
@@ -38,6 +39,7 @@ | |||
|
|||
public final class JdbcTableHandle | |||
extends BaseJdbcConnectorTableHandle | |||
implements ConnectorTableLocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have a SPI specific API in ConnectorMetadata
which would resolve location based on ConnectorTableHandle
?
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: