[Draft] Add support for JOIN PUSHDOWN in Exasol connector #26558
+615
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyglass
force-pushed
the
feature/750_join_push_down
branch
5 times, most recently
from
9dce6bc to
98b0b7e
Compare
ebyhr
requested changes
Sep 4, 2025
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
reviewed
Sep 5, 2025
plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
Show resolved
Hide resolved
skyglass
force-pushed
the
feature/750_join_push_down
branch
2 times, most recently
from
49489e2 to
183d636
Compare
skyglass
commented
Sep 9, 2025
There was a problem hiding this comment.
Resolved some review comments by adding tests for toWriteMapping and some other changes.
Also, in this improved solution BaseJdbcConnectorTest is not changed at all!
All necessary changes are done in TestExasolConnectorTest
testJoinPushdown() from BaseJdbcConnectorTest is enabled with SUPPORTS_JOIN_PUSHDOWN -> true flag
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolConnectorTest.java
Outdated
Show resolved
Hide resolved
skyglass
force-pushed
the
feature/750_join_push_down
branch
from
183d636 to
077acbe
Compare
skyglass
commented
Sep 9, 2025
There was a problem hiding this comment.
- Added test coverage for toWriteMapping and convertPredicate
- Removed all changes from BaseJdbcConnectorTest
- Splited the changes to 4 commits
Implementation of methods toWriteMapping and convertPredicate are required to make testJoinPushDown work.
Is it ok to keep these changes in one PR, or should I create separate PRs for each of these changes?
skyglass
force-pushed
the
feature/750_join_push_down
branch
3 times, most recently
from
d7b955c to
a320fe4
Compare
skyglass
force-pushed
the
feature/750_join_push_down
branch
from
a320fe4 to
d994c52
Compare
skyglass
changed the title
|
Converted this PR to DRAFT, because it contains many changes, which should be splited into several PRs.
Next PRs will be created later, after the first two merged. |
|
Closed, and will be used as DRAFT for implementing JOIN_PUSHDOWN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Exasol Trino connector support for JOIN PUSHDOWN by implementing connectorExpressionRewriter and convertPredicate in ExasolClient
Additional context and related issues
Release notes