Skip to content

Conversation

jonathongardner
Copy link
Contributor

@jonathongardner jonathongardner commented Jul 19, 2025

Description:

Find and verify webex bot tokens. Fixes #4321

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)? This was failing for me locally on unknown flag: --out-format without the flag still a lot of errors. Tested just on the added detector and it passed
webexbot-detector-tests

@jonathongardner jonathongardner requested review from a team as code owners July 19, 2025 00:55
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2025

CLA assistant check
All committers have signed the CLA.

@jonathongardner jonathongardner requested a review from a team as a code owner July 21, 2025 18:01
Copy link
Contributor

@shahzadhaider1 shahzadhaider1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you.
Added some feedback.

Copy link
Contributor

@shahzadhaider1 shahzadhaider1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathongardner ❤️

@kashifkhan0771 kashifkhan0771 merged commit d3459e6 into trufflesecurity:main Jul 28, 2025
13 checks passed
Jeff-Rowell pushed a commit to Jeff-Rowell/trufflehog that referenced this pull request Jul 29, 2025
* feat: add webexbot support

* build proto using make

* remove generic words

* added the secret scanner to the engine defaults

* remove keywords from regex and PR suggestions

* fixed pattern tests

* return err to set on results and remove duplicate keyword

---------

Co-authored-by: Shahzad Haider <[email protected]>
Co-authored-by: Shahzad Haider <[email protected]>
Co-authored-by: Kashif Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webex bot support
4 participants