-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add webexbot support #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thank you.
Added some feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonathongardner ❤️
* feat: add webexbot support * build proto using make * remove generic words * added the secret scanner to the engine defaults * remove keywords from regex and PR suggestions * fixed pattern tests * return err to set on results and remove duplicate keyword --------- Co-authored-by: Shahzad Haider <[email protected]> Co-authored-by: Shahzad Haider <[email protected]> Co-authored-by: Kashif Khan <[email protected]>
Description:
Find and verify webex bot tokens. Fixes #4321
Checklist:
make test-community
)?make lint
this requires golangci-lint)? This was failing for me locally onunknown flag: --out-format
without the flag still a lot of errors. Tested just on the added detector and it passed