`"username_display": "displayname"` does not work

[hrueschwein]

OS: openSUSE Tumbleweed
Iamb version: 0.0.8 (installed from OBS repo home:smolsheep)
Logs (level: debug): https://paste.opensuse.org/493c0afc2a1e
Config:

{
	"profiles": {
		"kvasyan": {
			"user_id": "@kvasyan:sibnsk.net",
			"url": "https://matrix.sibnsk.net"
		}
	},
	"default_profile": "kvasyan",
	"settings": {
		"log_level": "debug",
		"username_display": "displayname"
	},
	"layout": {
		"style": "restore"
	}
}

Thank you very much for your work! Unfortunately, i've faced one issue.

Iamb just puts Matrix ID (@user:example.com) instead of display names. Tried in rooms with from 10 to 500 members and even in dms.
It's very uncomfortable in rooms with bridges to other messengers, because every username transforms into sth like @telegram_12345678910:t2bot.io.

Thanks for attention.

[u20n]

+1
OS is Arch (via AUR), iamb -V returns iamb 0.0.9-alpha.1 (c7864cb).
Confirmed relevant config was being loaded, but display style doesn't change.

[u20n]

Actually updating to 0.0.9 did solve it. (whoops)

[hrueschwein]

Actually updating to 0.0.9 did solve it. (whoops)

But the latest release is 0.0.8...

[u20n]

v0.0.8 was released Jul 8, this issue was made Aug 20. Any progress would be on the v0.0.9 alpha, which is the git HEAD. There is some inconsistency whether or not displayname is shown, I've experienced both it working and not working with no change to the config file.

Possibly relevant logs:

Error("unknown variant `event_property_contains`, expected one of `event_match`, `contains_display_name`, `room_member_count`, `sender_notification_permission`", line: 1, column: 2552)
Error deserializing event Error("missing field `canonical`", line: 1, column: 22)

[u20n]

Removing the relevant session token fixes it for the rest of the session.

[photosheep]

Maintainer of that repo. I updated the repo to git HEAD to solve this. It required removal of session token like u20n says, but it works on latest repo. Downgraded afterwards to confirm confirm 0.0.8's username_display wasn't working properly.
Doing a zypper dup and cleaning session should fix the issue.

[olivia-fl]

I believe I found the source of the display_name inconsistency in v0.0.9 alpha while working on #168. The UI uses the RoomInfo::display_name field to look up user display names. This field is only updated when syncing the m.room.member event for the first time. When iamb is restarted, the room members are already persisted to the database, and this event handler is not triggered a second time. The only situations where display names work is during the first run of iamb for a given session and when somebody joins a room during the current run.

This should be fixable by populating the RoomInfo::display_names field from room.members_no_sync when a room is loaded. Probably worth checking that this doesn't eat all the CPU when iterating over all the members of a large room though.