Skip to content

wip: add more field types and deal with Enum in facets #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

wip: add more field types and deal with Enum in facets #2868

wants to merge 19 commits into from

Conversation

yohanboniface
Copy link
Member

@yohanboniface yohanboniface commented Aug 15, 2025 •
edited
Loading

fix #2843
fix #1570

Todo:

  • test for edit/rename where field exist both on datalayer and map
  • quick edit for filters from the browser
  • tests for undo/redo of field rename/delete
  • make filters orderable
  • find a way to edit the field type from the number edit form => add a link to go from filter to field and vice versa
  • adapt the input in the feature form according to the field type (if number, enum, date, etc.)
  • deal with parsing French dates (dd-mm-yyyy)
  • add a "field, filters and sort" fieldset
  • make clearer that there are fields on the map and on the layers
  • update widget list according to field type (do not show minmax for boolean, for example)
  • rename facet to filter in code and data (or vice-versa)
  • make filters work for boolean

@yohanboniface yohanboniface force-pushed the enum-field-type branch 3 times, most recently from 7fd9b95 to 971e780 Compare August 22, 2025 14:54
@davidbgk davidbgk mentioned this pull request Sep 9, 2025
Open
yohanboniface and others added 9 commits September 11, 2025 10:50
@yohanboniface
fix: fix reordering fields
6e17ec1
@yohanboniface
wip: keep order on field rename
c9b2db7 
Map will always respect the insertion order, so when updating
a field without rename it will update the existing entry, but when
the key changes, so it is like a new entry.
@yohanboniface
wip: allow to reorder fields
5f82dd5
@yohanboniface
wip: make sure fields are saved after changing their type
7da94c7
@yohanboniface
wip: introduce DateTimeInput
7da6c80
@yohanboniface @davidbgk
wip: merge fieldsets for fields, filters and keys management
0eedb1f 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: fix filters update
25cb468 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: poor man way of dealing with French formatted dates
01e9d57 
Co-authored-by: David Larlet <[email protected]>
@yohanboniface @davidbgk
wip: make sure we can undo a field rename
3a5102f 
Co-authored-by: David Larlet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Technical help] Filter keys pulled from multiple properties Multiple values for facet search
1 participant
@yohanboniface