Ada keyword "is" error

[guardian4096]

Hello,

Thank you for adding the Ada filetype to ctags.

I ran into a "Segmentation Fault" error while typing the hello_world Ada example program in Geany IDE version 2.

Note: the "Segmentation Fault" error occurred after typing "is" -- see animated gif below.

== "Segmentation Fault" Error Details ==
file: ada.c
directory: ctags/parsers/
issue: "Segmentation Fault" error after typing "is" in Geany IDE version 2
possible cause: line 1176, "else if (line[pos] == '(')"
possible fix: replace with "else if (adaCmp ("("))"
---- or ----
alternative fix: replace with "else if (!eof_reached && line[pos] == '(')"

......

The following is an example of a "Segmentation Fault" error causing Ada file:

:seg_fault_example.adb:
with Ada.Text_IO;

procedure Seg_Fault_Example is

seg_fault_example.adb.txt

......

The following is a copy of the "ada.c" file with my recommended fix; namely,
"from-ctags-version-6.2.0-see-line-1176-ada.c"

from-ctags-version-6.2.0-see-line-1176-ada.c.txt

Note: I also identified this issue on "Geany IDE" github's website.

I hope this information helps.

[b4n]

Thanks for your report, it should be fixed with #4285.

I seen a bit too late that you had already found the fix, but I went with the !eof_reached method because it seemed to be what the code currently does and is slightly faster (in theory), but your solution or the potentially more idiomatic line && line[pos] could have been reasonable solutions.
This said, given you had figured the patch and submitted this thorough report, why not make a pull request yourself? 🙂

Anyway, please give #4285 a spin, but it should work, and is actually identical to your alternative suggested fix.

[guardian4096]

Hello,

I made the same change identified in your pull request to the ada.c file and it did correct the "Segmentation Fault" error I was getting--i.e., I did not get the "Segmentation Fault" error.

Thank you for taking the time to correct this issue and for adding a unit test to prevent this issue from occurring in the future.