Skip to content

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 23, 2025

What?

This fixes a bug where memory is not released back to the OS.

Closes PACK-5126

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jul 23, 2025
Copy link
Member Author

sokra commented Jul 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra marked this pull request as ready for review July 23, 2025 23:08
@sokra sokra requested a review from bgw July 23, 2025 23:09
@sokra sokra force-pushed the sokra/update-mimalloc branch from 053db20 to b4ce961 Compare July 23, 2025 23:17
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Performance Report

Merging #81993 will not alter performance

Comparing sokra/update-mimalloc (b4ce961) with canary (08ee5f6)

Summary

✅ 9 untouched benchmarks

@sokra sokra merged commit 63dba67 into canary Jul 24, 2025
165 checks passed
Copy link
Member Author

sokra commented Jul 24, 2025

Merge activity

  • Jul 24, 12:23 AM UTC: @sokra merged this pull request with Graphite.

@sokra sokra deleted the sokra/update-mimalloc branch July 24, 2025 00:23
Copy link
Member

bgw commented Jul 24, 2025

Because I was curious: This translates to an upgrade from mimalloc v2.1.6 to v2.2.4

bgw pushed a commit that referenced this pull request Jul 29, 2025
### What?

This fixes a bug where memory is not released back to the OS.
bgw added a commit that referenced this pull request Jul 29, 2025
We're heard about significant real-world reductions in memory usage from
this change in canary. It seem relatively low-risk, so IMO we should
backport it.

Original PR: #81993

Co-authored-by: Tobias Koppers <[email protected]>
@github-actions github-actions bot added the locked label Aug 7, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants