Skip to content

Encode attribute values #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Encode attribute values #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,14 @@ export function segment(
: [...graphemeSegmenter.segment(content)].map((seg) => seg.segment)
}

function encodeAttributeValue(value: string) {
return value
.replace(/"/g, '"')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/&/g, '&amp;')
}

export function buildXMLString(
type: string,
attrs: Record<string, any>,
Expand All @@ -193,7 +201,11 @@ export function buildXMLString(

for (const [k, _v] of Object.entries(attrs)) {
if (typeof _v !== 'undefined') {
attrString += ` ${k}="${_v}"`
if (typeof _v === 'string') {
attrString += ` ${k}="${encodeAttributeValue(_v)}"`
} else {
attrString += ` ${k}="${_v}"`
}
}
}

Expand Down