fix(loading): Prevent isLoading from being true with fallbackData #4140
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `fallbackData` is provided, `isLoading` should not be true initially. Instead, `isValidating` should be true to indicate background revalidation. This prevents a "flash of skeleton" UI when initial data is available. Fixes vercel#3046
…Data" This reverts commit 2bc18a2.
When `fallbackData` is provided, `isLoading` should not be true initially. Instead, `isValidating` should be true to indicate background revalidation. This prevents a "flash of skeleton" UI when initial data is available. Fixes vercel#3046
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Would love to have a test case for this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
isLoadingwas incorrectly set totrueeven whenfallbackDatawas provided, particularly in SSR scenarios. This led to a "flash of skeleton" UI, which is undesirable when initial data is already available.The change modifies the logic to ensure that
isLoadingremainsfalsewhenfallbackDatais present, whileisValidatingcorrectly reflects the background revalidation process. This allows the initial server-cached data to be displayed immediately, providing a smoother user experience.Fixes #3046