Update Dockerfile.photon-2.0 due to url changed #8590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8590 +/- ##
=========================================
- Coverage 31.51% 31.4% -0.12%
=========================================
Files 293 293
Lines 44382 44382
=========================================
- Hits 13986 13937 -49
- Misses 29173 29223 +50
+ Partials 1223 1222 -1
Continue to review full report at Codecov.
|
ading007
force-pushed
the
update_vchpkg_dockerfile
branch
from
f63b80c to
76463b2
Compare
DanielXiao
reviewed
Sep 16, 2019
| RUN wget -e robots=off -r -nH -nd -np -R $EXCLUDE_LIST https://dl.bintray.com/vmware/photon_release_2.0_x86_64/noarch/ -P /usr/share/nginx/html/photon/noarch/ | ||
| RUN wget -e robots=off -r -nH -nd -np -R $EXCLUDE_LIST https://dl.bintray.com/vmware/photon_updates_2.0_x86_64/x86_64/ -P /usr/share/nginx/html/photon-updates/x86_64/ | ||
| RUN wget -e robots=off -r -nH -nd -np -R $EXCLUDE_LIST https://dl.bintray.com/vmware/photon_updates_2.0_x86_64/noarch/ -P /usr/share/nginx/html/photon-updates/noarch/ | ||
| RUN wget -qO- https://dl.bintray.com/vmware/photon_release_2.0_x86_64/x86_64/ | grep -i "</a>" | cut -d : -f 2 | cut -d '"' -f 1 | xargs -I {} wget -e robots=off -r -nH -nd -np -R $EXCLUDE_LIST https://dl.bintray.com/vmware/photon_release_2.0_x86_64/x86_64/{} -P /usr/share/nginx/html/photon/x86_64/ |
There was a problem hiding this comment.
- Why do you still use recursive download?
- Use a regex to grep out the rpm name would be easier for maintenance than cut.
ading007
force-pushed
the
update_vchpkg_dockerfile
branch
from
76463b2 to
76e1305
Compare
DanielXiao
approved these changes
Sep 16, 2019
luwang-vmware
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing.
[skip ci]