Skip to content

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 5, 2025

No description provided.

@foolip
Copy link
Member Author

foolip commented Sep 5, 2025

@mfreed7 @josepharhar can you help me review this? It was unusually difficult to discern which tests are for which feature, with tests found in a lot of different directories, for different features. Here are all of the files not mapped here that have the word "commandfor" in them:

html/semantics/interactive-elements/the-details-element/details-toggle-source.html
html/semantics/interactive-elements/the-dialog-element/dialog-toggle-source.html
html/semantics/menu/tentative/button-invoke-menulist.html
html/semantics/menu/tentative/focus-menu-elements-arrowoperations.html
html/semantics/menu/tentative/focus-menu-elements-nested-arrowoperations.html
html/semantics/menu/tentative/menubar-invoke-menulist.html
html/semantics/menu/tentative/menuitem-activate.html
html/semantics/popovers/popover-focus-2.html
html/semantics/popovers/popover-focus-3.html
html/semantics/popovers/popover-focus-4.html
html/semantics/popovers/popover-light-dismiss-command.html
html/semantics/popovers/popover-toggle-source.html
html/semantics/popovers/popovertarget-disabled-fieldset.html
shadow-dom/focus-navigation/menu/tentative/focus-menu-elements.html
shadow-dom/reference-target/tentative/commandfor.html
shadow-dom/reference-target/tentative/resources/property-reflection-helper.js

Should anything in this list be considered tests primarily for command/commandfor?

@foolip foolip force-pushed the web-features/invoker-commands branch from 64c72f2 to 6885375 Compare September 5, 2025 09:11
@josepharhar
Copy link
Contributor

html/semantics/popovers/popovertarget-disabled-fieldset.html seems closely related enough to commandfor that I'd include it.

html/semantics/popovers/popover-light-dismiss-command.html seems like a copy of popover-light-dismiss.html which uses command attributes instead of popovertarget. I'm not sure why it was created, but it primarily tests light dismiss. I'm not sure if it should be considered part of command/commandfor or not.

The rest of the tests I'm pretty sure are not primarily for command/commandfor.

@mfreed7
Copy link
Contributor

mfreed7 commented Sep 5, 2025

html/semantics/popovers/popovertarget-disabled-fieldset.html seems closely related enough to commandfor that I'd include it.

html/semantics/popovers/popover-light-dismiss-command.html seems like a copy of popover-light-dismiss.html which uses command attributes instead of popovertarget. I'm not sure why it was created, but it primarily tests light dismiss. I'm not sure if it should be considered part of command/commandfor or not.

The rest of the tests I'm pretty sure are not primarily for command/commandfor.

+1 to all of this. I think it's just that command is so useful that it gets used as a "feature" in other tests, to test other things. That plus several new features (e.g. reference target and menu) need to consider command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants