[Masonry] Adding support for Masonry out-of-flow items #54728
Merged
+1,810
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL implements out-of-flow support in masonry (outside of fragmentation). - Enhanced `placeOutOfFlowItems` to properly handle OOF items with correct containing block calculation, alignment offset computation, and static positioning. - Extended `out_of_flow_layout_part` to recognize masonry containers and delegate OOF item placement to the masonry-specific containing block calculation. Bug: 343257585 Change-Id: I0ecccb7b2e6c3a46a810bd01577a88d53b05d7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909974 Reviewed-by: Kurt Catti-Schmidt <[email protected]> Commit-Queue: Yanling Wang <[email protected]> Reviewed-by: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1511947}
wpt-pr-bot
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements out-of-flow support in masonry (outside of
fragmentation).
placeOutOfFlowItemsto properly handle OOF items withcorrect containing block calculation, alignment offset computation,
and static positioning.
out_of_flow_layout_partto recognize masonry containersand delegate OOF item placement to the masonry-specific containing
block calculation.
Bug: 343257585
Change-Id: I0ecccb7b2e6c3a46a810bd01577a88d53b05d7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909974
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Commit-Queue: Yanling Wang <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1511947}