Skip to content

Add support for removing unused type ignores with error codes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Add support for removing unused type ignores with error codes #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ba93e3
Add support for removing unused type ignores with error codes
patrick91 Apr 6, 2022
db72ea0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions mypy_silent/maho.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import re
from typing import Optional


_type_ignore_re = re.compile(r"# type: ignore(\[[a-z, \-]+\])?")


def add_type_ignore_comment(line: str, error_code: Optional[str]) -> str:
# Workarounds for https://mypy.readthedocs.io/en/stable/common_issues.html#silencing-linters

Expand All @@ -22,9 +26,6 @@ def add_type_ignore_comment(line: str, error_code: Optional[str]) -> str:
def remove_type_ignore_comment(line: str) -> str:
content_without_crlf = line.rstrip("\r\n")
return (
content_without_crlf.replace("# type: ignore", "#")
.rstrip()
.rstrip("#")
.rstrip()
_type_ignore_re.sub("#", content_without_crlf).rstrip().rstrip("#").rstrip()
+ line[len(content_without_crlf) :]
)
2 changes: 2 additions & 0 deletions tests/test_maho.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ def test_add_type_ignore_comment_with_error_code() -> None:
" host, port, protocol = m.groups()\r\n",
),
("# type: ignore. very good", "#. very good"),
("# type: ignore[misc]. very good", "#. very good"),
("# type: ignore[misc, arg-type]. very good", "#. very good"),
),
)
def test_remove_type_ignore_comment(input: str, output: str) -> None:
Expand Down