Skeleton layout fundamentally broken. ABSPATH already set.

[crazyjaco]

Hello. I am trying to see if this box will work with my company's WordPress theme.
I am using a Skeleton layout to abstract my content folder from core.

I am noticing the following lines in the wp-config.php in the www folder:

if ( ! defined( 'ABSPATH' ) ) {
	if ( 'standard' === BOX_DIRECTORY_LAYOUT ) {
		define( 'ABSPATH', dirname( __FILE__ ) . '/' );
	} else if ( 'skeleton' === BOX_DIRECTORY_LAYOUT ) {
		define( 'ABSPATH', dirname( __FILE__ ) . '/wp/' );
	}
}

Unfortunately, it will never enter this logic because ABSPATH will always be defined before the wp-config.php file is loaded.
ABSPATH is set in the wp-load.php just before it then loads wp-config.php.

This means a skeleton layout will always break. :\

Even if I changed the above snippet to:

if ( 'skeleton' === BOX_DIRECTORY_LAYOUT ) {
		define( 'ABSPATH', dirname( __FILE__ ) . '/wp/' );
}

This wouldn't work either because then you are setting a constant twice, which will throw a php error.

There is no way to use a skeleton layout using a wp-config.php file within a separate wordpress install.
The wp-config.php needs to be in a parent directory of core.

This a fundamental architecture problem and I'm not sure there is a quick solution, not having worked in this box for more than a few hours.

I get further by deleting all the wordpress files in the root of www except the wp-config files and navigating to my.hostname/wp, but then there is a problem in the wp-config.php trying to get the correct hostname.

[mikeschinkel]

@crazyjaco Thanks for the report. I will check on this in the next few hours and get back to you with a solution.

[crazyjaco]

still troubleshooting.
I tried creating a HOSTNAME file in the root of the project but the code didn't seem to acknowledge it.
since I'm using a skeleton layout, I changed the condition on line 4 of wp-config.php to

if ( getcwd()=='/var/www/wp' && isset( $_SERVER[ 'HTTP_HOST' ] ) ) {

That gets me the correct project wp-config-{host}.php file loading.

I'm breaking further along now, but it seems to be much further in the bootstrap.

[mikeschinkel]

@crazyjaco I am booting up a new setup to debug it now.

[mikeschinkel]

@crazyjaco BTW, I have worked on this to replace the rats nest that is typical wp-config.php configuration, but I had to task switch so did not complete all the issues. I will be able to complete it soon after which I'll tag it as 1.0:

https://github.com/wplib/better-wp-config

[crazyjaco]

Thanks Mike! Appreciate it.
Sorry we didn't see you at WordCamp for Publishers in Chicago. ;)
Hope you are well.

Thats an interesting repo. I'm going to have to give a closer look when I get a chance.

[mikeschinkel]

@crazyjaco I was working on a critical project and could not take the time away.

That said, I have decided to pull back from client work and focus 100% on (finally) getting the successor to WPLib Box out the door.

Have you signed up to our Slack? In case you have questions?

https://launchpass.com/wplib

[mikeschinkel]

@crazyjaco Can you try this one as an candidate for our next release?

https://gist.github.com/mikeschinkel/6db474d6e6ac1b4b2aa6071843a6b264

[crazyjaco]

Hey @mikeschinkel,

Just getting back to this. That gist seemed to work. I can get to the admin login screen for wp-admin. Which means it found my imported database with a custom table prefix. So thats a good start.
Something is up for displaying the site's frontend, but I'm not far into debugging that yet. It might be on my side.

I'll check out the slack.
How do I access WP-CLI?

[mikeschinkel]

How do I access WP-CLI?

vagrant ssh then wp should work. Not 100% of it works, so we need bug reports for what does not.

You (currently) must have "wordpress/cliapp": "wplib/wp-cli:1.5.1", in your project.json's "stack".

ALSO, I had to update the Gist to support WP CLI. I did not test with it earlier.

[crazyjaco]

looks like i can access wp-cli, but it can't find the right wordpress install. It using the wrong table prefix (wp_ instead of my custom one).

i have my wp-config.php in the root of www.

www

• wp
• content
  wp-config.php
  wp-config-boston.local.php

boxuser@boston:/var/www/wp$ wp user list --path='/var/www/wp'
Error: The site you have requested is not installed.
Your table prefix is 'wp_'. Found install with table prefix: BGMP_.
Or, run `wp core install` to create database tables.

[mikeschinkel]

@crazyjaco That looks like a WP CLI configuration error? (I don't use WP-CLI that often.)

[crazyjaco]

I think I see the issue.
It seems that $hostname is not yet set in the wp-config.php, when we check it on line 22(ish).
$hostname wouldn't be set because we aren't accessing the page load via a url, but via a command line invocation.

[mikeschinkel]

@crazyjaco Did you get the latest Gist I posted in the past hour? I had to fix that $hostname problem.

[crazyjaco]

Yes.
My hostname is not wplib.box.
And the $_SERVER['HTTP_HOST'] won't be set to the correct value if we're coming in via WP-CLI invocation.

[crazyjaco]

oh wait. I'm seeing i need to create a HOSTNAME file to hardcode it since its different.
So it would work without for a normal page request, but not a WP-CLI request.