[Bug]: PnP linker does not work with docusaurus

[alubbe]

Self-service

• I'd be willing to implement a fix

Describe the bug

Using the PnP linker with docusaurus (specifically, running yarn build) leads to this error:

[ERROR] The image at yarn2-docusaurus-bug/static/img/docusaurus.png can't be read correctly. Please ensure it's a valid image.
The "path" argument must be of type string. Received type number (27)

Setting nodeLinker: node-modules fixes everything.

To reproduce

Clone https://github.com/alubbe/yarn2-docusaurus-bug, run yarn install followed by yarn build to see the errors.

Then set nodeLinker: node-modules (or revert the current commit), run yarn install followed by yarn build to see that it all works again.

This repo was created by simply running npx create-docusaurus@latest my-website classic.

Environment

System:
    OS: macOS 10.15.7
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 16.13.2 - /private/var/folders/3q/__zqxvrj0pqdmv03_3hkknl00000gn/T/xfs-c06aa74c/node
    Yarn: 3.1.1 - /private/var/folders/3q/__zqxvrj0pqdmv03_3hkknl00000gn/T/xfs-c06aa74c/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.2/bin/npm

Additional context

No response

[alubbe]

Gentle poke here - I know you are all incredibly busy, so I understand you may not have the time to debug this. What commands could I run myself to provide you with logs/info that could help understand how to fix this?

[arcanis]

I haven't looked into it yet, but when I saw the error message the first thing that popped into my mind was either something like a Webpack require.resolve being passed to a fs method (the Webpack require.resolve returns module IDs, not paths), or something about file descriptors. But not sure it'd only affect PnP 🤔

[alubbe]

I was thinking along the same lines, but I don't know where to start the debugging journey. Any pointers? Or would it make sense to ask the docusaurus team if they have an idea from just glancing at it?

[merceyz]

Will most likely be fixed by #3889

[Josh-Cena]

This warning's cause is #3889 (comment), and yes, I did spend a while poking around it last month (didn't see this issue back then)... This warning has been suppressed in Docusaurus as well, in facebook/docusaurus#6779. It's not ideal, so hoping #3889 can land soon :D

[yarnbot]

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

[Josh-Cena]

It's not not reproducible though :/ Can confirm it's always relevant and I'm really looking forward to removing that check from facebook/docusaurus#6779