feat(interactive-tools): show workspaces info in upgrade-interactive
#3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semanser
force-pushed
the
semanser/show-workspaces-in-upgrade-interactive
branch
2 times, most recently
from
c10fc5d to
287b451
Compare
2 tasks
bryanph
suggested changes
Sep 11, 2021
|
Is there anything I can do to help with this PR? |
semanser
force-pushed
the
semanser/show-workspaces-in-upgrade-interactive
branch
from
287b451 to
d5b0bae
Compare
|
Fixed all the issues!
|
|
bump, I would love to see this merged! |
2 tasks
|
Any blockers for this one? Would love to see this change, this would make upgrading a monorepo with many workspaces a lot easier 😄 . |
|
Anything blocking this? |
|
Desperately need this as well. |
|
Need the author to fix conflicts before this can be further looked at. |
|
Please, can someone have a look at the conflicts? I desperately need this 🙏 |
|
New Year, new bump. Here's to wishing this merges in 2023! |
|
Just pointing out the obvious and not trying to be mean but without this in a monorepo with many workspaces, upgrade-interactive is almost useless. Is there at least a timeline for getting this reviewed? |
|
Any news? |
|
A few years have passed, any news? |
|
Ran into this today. Would like this to be merged please. |
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2025
## What's the problem this PR addresses? 👋 Hello! I was randomly looking at the `@yarnpkg/cli` bundle, and esbuild reported a few warnings (when building locally in the repo, and inspecting on https://esbuild.github.io/analyze/ ). One of these warnings, was that there are some duplicated external libraries - such as `chalk`.  <details><summary>Full bundle graph</summary> <img src="https://github.com/user-attachments/assets/99133d9b-5bbf-4390-84ab-b608ef301501" /> </details> The savings from this PR are tiny (a few kb), but worth doing :) ## What does this PR do This PR bumps chalk to consistently be [v4.1.2 ](https://github.com/chalk/chalk/releases/tag/v4.0.0) up from v `3.0.0`. The diff for 3.0.0 to 4.0.0 is [here](chalk/chalk@v3.0.0...v4.0.0). The only relevant breaking change is dropping node 8 support, which should suffice for yarn (current engines of yarn is set to 18). > [!NOTE] > I didn't opt for [v5 ](https://github.com/chalk/chalk/releases/tag/v5.0.0)- as it's esm only, and may require some config tweaking. V5 **is** a smaller bundle though, ~half the size! /aside - It would be a larger bundle saving to remove the dependency entirely to something like https://www.npmjs.com/package/picocolors - but that's potentially a larger piece of work, as `@yarnpkg/shell` [uses some bespoke colors ](https://github.com/yarnpkg/berry/blob/master/packages/yarnpkg-shell/sources/index.ts#L815-L815). I tried to bump ink, as they've made some improvements too - but it seems they expect tools to bundle with an `esm` format - wheras yarn is currently bundling as `iife`, so would require decent patching or upstream changes ( I couldn't get either to work just yet). ## How did you fix it? `yarn upgrade-interactive` to specify v4 of chalk :) Note that yarn upgrade-interactive is difficult to use when using workspaces, until #3260 (or similar) are closed. Similarly reported in #2591 #3281. ## Checklist - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Allows to show a corresponding dependency workspace when using
yarn upgrade-interactive --show-workspacescommand.Before
After
Closes: #2591 #3281
Checklist