Skip to content

Conversation

larixer
Copy link
Member

@larixer larixer commented Mar 7, 2022

What's the problem this PR addresses?

There is a large-scale war happening in Ukraine with the 3rd largest army in the world with a non-zero risk to become a world war, we should show our stance somehow so that more people were aware and helped stop the Russian agression.

How did you fix it?

Adds a banner to Yarn website.

image

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the scroll-padding-top value to match the new height of the top bar (ref #3932), otherwise LGTM

@larixer larixer requested review from arcanis and paul-soporan March 7, 2022 18:33
Copy link
Member

@paul-soporan paul-soporan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the Ukrainian flag could become a clickable link to the stand with Ukraine page too, if not the entire banner itself 🤔

@arcanis arcanis force-pushed the master branch 2 times, most recently from b296f85 to c225c1f Compare March 7, 2022 23:36
@arcanis arcanis merged commit 4c81399 into master Mar 8, 2022
@arcanis arcanis deleted the larixer/ukraine-support branch March 8, 2022 08:11
arcanis pushed a commit that referenced this pull request Mar 24, 2022
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Sep 21, 2022
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Oct 5, 2022
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Nov 16, 2022
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Dec 20, 2022
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Feb 1, 2023
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Mar 16, 2023
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request May 1, 2023
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Jun 1, 2023
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
merceyz added a commit that referenced this pull request Nov 14, 2023
* Adds Ukraine support banner

* Update packages/gatsby/src/components/header.js

Co-authored-by: Kristoffer K. <[email protected]>

* Updates scroll padding top height to account for banner

Co-authored-by: Kristoffer K. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants