-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: Add Ukraine support banner to Yarn website #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the scroll-padding-top
value to match the new height of the top bar (ref #3932), otherwise LGTM
Co-authored-by: Kristoffer K. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the Ukrainian flag could become a clickable link to the stand with Ukraine page too, if not the entire banner itself 🤔
b296f85
to
c225c1f
Compare
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
* Adds Ukraine support banner * Update packages/gatsby/src/components/header.js Co-authored-by: Kristoffer K. <[email protected]> * Updates scroll padding top height to account for banner Co-authored-by: Kristoffer K. <[email protected]>
What's the problem this PR addresses?
There is a large-scale war happening in Ukraine with the 3rd largest army in the world with a non-zero risk to become a world war, we should show our stance somehow so that more people were aware and helped stop the Russian agression.
How did you fix it?
Adds a banner to Yarn website.
Checklist