refactor(core): use const for descriptor in LegacyMigrationResolver
#4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
trivikr/core/const-descriptor
branch
3 times, most recently
from
370247a to
7e1b364
Compare
trivikr
force-pushed
the
trivikr/core/const-descriptor
branch
2 times, most recently
from
b0c3ebb to
56daa8c
Compare
trivikr
force-pushed
the
trivikr/core/const-descriptor
branch
from
56daa8c to
0cf02fe
Compare
merceyz
force-pushed
the
trivikr/core/const-descriptor
branch
from
0cf02fe to
160f835
Compare
merceyz
previously approved these changes
Jul 12, 2022
merceyz
changed the title
LegacyMigrationResolver
auto-merge was automatically disabled
July 18, 2022 02:46
Head branch was pushed to by a user without write access
trivikr
force-pushed
the
trivikr/core/const-descriptor
branch
from
bf1c242 to
6542f01
Compare
auto-merge was automatically disabled
September 26, 2022 23:07
Head branch was pushed to by a user without write access
trivikr
force-pushed
the
trivikr/core/const-descriptor
branch
from
6542f01 to
38d367e
Compare
merceyz
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The variable
descriptorcan be declared as const, and assigned values in a conditional operator. Another const can be used for initial parsed descriptor.How did you fix it?
Use const for variable
descriptor, and introduce new constparsedDescriptorChecklist