fix(core): ensure proper install for git dependency using Yarn classic and npm

.yarn/versions/df71c502.yml

@@ -0,0 +1,33 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/core": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/HEAD

@@ -0,0 +1 @@
+ref: refs/heads/master

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/config

@@ -0,0 +1,6 @@
+[core]
+	repositoryformatversion = 0
+	filemode = true
+	bare = true
+	ignorecase = true
+	precomposeunicode = true

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/description

@@ -0,0 +1 @@
+Unnamed repository; edit this file 'description' to name the repository.

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/hooks/post-update

@@ -0,0 +1,8 @@
+#!/bin/sh
+#
+# An example hook script to prepare a packed repository for use over
+# dumb transports.
+#
+# To enable this hook, rename this file to "post-update".
+
+exec git update-server-info

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/info/exclude

@@ -0,0 +1,6 @@
+# git ls-files --others --exclude-from=.git/info/exclude
+# Lines that start with '#' are comments.
+# For a project mostly in C, the following would be a good set of
+# exclude patterns (uncomment them if you want to use them):
+# *.[oa]
+# *~

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/info/refs

@@ -0,0 +1 @@
+c617d6c53537945167b6b0b5458a64017d975330	refs/heads/master

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/82/7e0acbbaef8b219d61bb2cc06fcc546b365816

@@ -0,0 +1,3 @@
+x
U��
+�0E]�+�l�1�ATt�wym$Q
+�7m#�l�=�콄n�[�	��NX��7�X��z0,]/qRф�Jc��L�}1iC�������#�!���`�96p�4�����^��
K�T��g��~��ܵ�-o�����C9�

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/bd/2ecbdfe85280f2f2e466a45917dd8026cacd4a

@@ -0,0 +1,2 @@
+x
��Aj�0Eg�S�Sdɉ(�0'�e�	'!qs�f����<��t�un@n�0�P"a
+�"�O�0�Ƃ���$0r��6����JN8J֮�Џ<������L�N~۴�ؖy�����O}�C����ʼ\�~��;����ᎌ�.{E6���Mr�~�.��u��S|JK

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/c6/17d6c53537945167b6b0b5458a64017d975330

@@ -0,0 +1,2 @@
+x
��Q
+�0D��)��v��	��d��آiK?���#�5���̥������B�[R��Ŧu>��6du-E�Q0u���,��T!����w�1S&�α�Bӧ䑜�$ˆ_u�W���q�o���|�$_t��{/h\� �`�E4;�OV�sn�`Yuay���
[DK�

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/df/60be62249ddb4da7c0477253fba48c6a4c4497

@@ -0,0 +1,2 @@
+x
U��
+�0�=�)�\z���{�9��]0�lB�����M�@�8��͘�P�:|2H'H;g�E�t�*(8q\�
#[O�G)KY�:7ц���r֖�q�R��G�����C�c�g��I]r��R��|�X������
�GM����S�sݽJ�ʍ�M���?

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/e5/eb942edb80fabc5d146fc412fc8ba3c21732ec

@@ -0,0 +1,3 @@
+x
��[
+�0E��*f�䝂�ЕL�������ݛn��s9p9\r�*�Nu
���1����g/� �O6
+�4h炷��O�}��z��W>p�C�_����|�F���"�f[�ʟw5��&+��5��;�

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/objects/info/packs

@@ -0,0 +1,4 @@
+P pack-8b0f2d0cb990021d1d21fc0f977b98c71abf4556.pack
+P pack-7842457b37632707b6cc2577d70e42a0145d5416.pack
+P pack-ed8ae5f84f4ca53ee2f02377d768b2593581ba96.pack
+

packages/acceptance-tests/pkg-tests-fixtures/repositories/has-prepack-npm.git/packed-refs

@@ -0,0 +1,2 @@
+# pack-refs with: peeled fully-peeled sorted 
+c617d6c53537945167b6b0b5458a64017d975330 refs/heads/master

packages/acceptance-tests/pkg-tests-specs/sources/protocols/git.test.js

@@ -149,6 +149,35 @@ describe(`Protocols`, () => {
       45000,
     );
 
+    test(
+      `it should guarantee that all dependencies will be installed when using npm to setup npm repositories`,
+      makeTemporaryEnv(
+        {
+          dependencies: {
+            [`has-prepack-npm`]: startPackageServer().then(url => `${url}/repositories/has-prepack-npm.git`),
+          },
+        },
+        async ({path, run, source}) => {
+          await expect(run(`install`, {
+            env: {
+              // if this is set then npm will be executed as if `--omit=dev` was passed during the install
+              // but `has-prepack-npm` requires dev dependencies to be present so this is a good way to
+              // verify that yarn isn't throw off by this when handling the clone, install, and pack process
+              // for git dependencies (see: https://docs.npmjs.com/cli/v8/using-npm/config#omit)
+              NODE_ENV: `production`,
+
+              // also force npm to use the package server as the registry so that the `has-bin-entry`
+              // dependency can be resolved
+              NPM_CONFIG_REGISTRY: await startPackageServer(),
+            },
+          })).resolves.toBeTruthy();
+
+          await expect(source(`require('has-prepack-npm')`)).resolves.toEqual(42);
+        },
+      ),
+      45000,
+    );
+
     test(
       `it should support installing specific workspaces from npm repositories`,
       makeTemporaryEnv(

packages/yarnpkg-core/sources/scriptUtils.ts

@@ -326,7 +326,10 @@ export async function prepareExternalProject(cwd: PortablePath, outputPath: Port
             // We can't use `npm ci` because some projects don't have npm
             // lockfiles that are up-to-date. Hopefully npm won't decide
             // to change the versions randomly.
-            const install = await execUtils.pipevp(`npm`, [`install`], {cwd, env, stdin, stdout, stderr, end: execUtils.EndStrategy.ErrorCode});
+            const install = await execUtils.pipevp(`npm`, [
+              `install`,
+              ...[`dev`, `prod`, `optional`, `peer`].map(include => `--include=${include}`),
+            ], {cwd, env, stdin, stdout, stderr, end: execUtils.EndStrategy.ErrorCode});
             if (install.code !== 0)
               return install.code;