fix(dlx): don't report UNUSED_PACKAGE_EXTENSION warnings

[paul-soporan]

What's the problem this PR addresses?

yarn dlx reports UNUSED_PACKAGE_EXTENSION warnings when an extension is unused in the temporary project created by dlx, even if it is used in the actual project the command is run in.

How did you fix it?

Made dlx filter out all UNUSED_PACKAGE_EXTENSION warnings via logFilters since they should only be about the main project.

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

• I will check that all automated PR checks pass before the PR gets reviewed.

[merceyz]

There is a config created on the following line when there is no .yarnrc.yml in the Project which should also be updated.

berry/packages/plugin-dlx/sources/commands/dlx.ts

Line 97 in 235f5a7

await xfs.writeFilePromise(targetYarnrc, `enableGlobalCache: ${enableGlobalCache}\nenableTelemetry: false\n`);

(You can also change that to a xfs.writeJsonPromise)

[paul-soporan]

Thanks, completely forgot about that one. I've also taken this opportunity to create a better merge function in miscUtils and use it everywhere since lodash's default one doesn't merge arrays.

[arcanis]

Why do we need these utils? Does the yaml stringifier supports serializing the comments?

[paul-soporan]

lodash's merge doesn't merge arrays, it just overwrites them, so when merging the dlxConfiguration with the project configuration it doesn't merge the logFilters of the two configurations.

Because of this, I needed to implement a util that does merge arrays using lodash's mergeWith, but I realized that we already have a function that does the same thing - the one in sdkUtils that merges our new settings with the .vscode files and preserves CJSON comments.

Because I didn't want to duplicate code, I extracted that one to miscUtils and added more tests and replaced all existing usages of lodash merge / mergeWith for consistency.

Does the yaml stringifier supports serializing the comments?

Nope.

Resolved