fix(pnp): return shortCircuit from the ESM loader hooks
#4624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
merceyz
added a commit
that referenced
this pull request
Jul 20, 2022
tumidi
added a commit
to innodoc/innodoc-webapp
that referenced
this pull request
Feb 29, 2024
- Modularize - Add workaround for eslint/eslint#3458 https://github.com/microsoft/rushstack/blob/main/eslint/eslint-config/patch/modern-module-resolution.js - Enable pnp esm loader - Project directory restructure /packages/client-web/e2e -> /e2e /packages/client-web -> /app rename packages/* - Use yarn canary until yarnpkg/berry#4624 is released. - Remove old tests (must be ported to RTL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node.js v18.6 requires that loaders explicitly return
shortCircuit: truewhen they don't call the next loader in the chain.How did you fix it?
Update the hooks.
Checklist