Skip to content

fix(pnp): automatically unplug open and opn #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2022
Merged

fix(pnp): automatically unplug open and opn #4633

merged 1 commit into from
Jul 16, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 16, 2022

What's the problem this PR addresses?

The package open doesn't work with PnP without users manually unplugging it.

Closes #856

How did you fix it?

Add open and opn to FORCED_UNPLUG_PACKAGES.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit b8d2315 into master Jul 16, 2022
@arcanis arcanis deleted the merceyz/fix/force-unplug-open branch July 16, 2022 18:21
merceyz added a commit that referenced this pull request Jul 20, 2022
@merceyz
fix(pnp): automatically unplug open and opn (#4633)
7abe377
@legobeat legobeat mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] open: spawn ENOTDIR
2 participants
@merceyz @arcanis