Skip to content

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Aug 10, 2022

What's the problem this PR addresses?

I noticed a few errors that weren't going through ReportError, and thus caused useless stacktraces to be displayed.

How did you fix it?

Added new error codes for them (I didn't see ones that matched their semantics) along with some basic documentation.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 3741be5 into master Aug 11, 2022
@arcanis arcanis deleted the mael/more-errors branch August 11, 2022 09:37
merceyz pushed a commit that referenced this pull request Dec 25, 2023
* Clean up a few extra errors

* Versions

* Update MessageName.ts

(cherry picked from commit 3741be5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant