Adds a note about workspaces in the enableScripts documentation
#4781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
added a commit
to krassowski/jupyterlab
that referenced
this pull request
Mar 24, 2023
… `ignore-optional` see: - yarnpkg/yarn#7338 (comment) / yarnpkg/berry#4781 - yarnpkg/berry#2412
merceyz
pushed a commit
that referenced
this pull request
Oct 21, 2023
) Update yarnrc.json (cherry picked from commit 6687804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
enableScriptssetting currently only applies to third-party packages. I believe it's because we ideally would want installs to be made withenableScriptsset to false by default (for security reasons), but there's no point into blocking the workspaces'postinstallscripts by default (since it doesn't improve security).Closes #4780
Ref #4386
Ref #4547
How did you fix it?
Updated the documentation.
Checklist