chore(bench): remove pnpm metadata cache in full-cold #4866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
previously approved these changes
Sep 18, 2022
merceyz
previously requested changes
Sep 18, 2022
merceyz
dismissed
their stale review
npm cache clean --force already clears it
paul-soporan
changed the title
merceyz
approved these changes
Sep 18, 2022
paul-soporan
deleted the
paul/chore/pnpm-bench-remove-metadata-cache
branch
merceyz
pushed a commit
that referenced
this pull request
Oct 21, 2023
(cherry picked from commit ebc9ede)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Pnpm uses a request metadata cache so that it doesn't have to hit the network when rebuilding the lockfile unless the data is stale, but we don't clear it in the relevant benchmarks.
How did you fix it?
Removed
~/.cache/pnpmin:cache-only, since it's supposed to test how much it takes to resolve all packages (without caching)Actually, we wantcache-onlyto test real-life conditions so metadata caching is fair game.Checklist