perf(patch): compute hash from the effects of the patch #4945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
merceyz
force-pushed
the
merceyz/perf/improve-patch-checksum
branch
2 times, most recently
from
3bafa04 to
cee9d9e
Compare
merceyz
force-pushed
the
merceyz/perf/improve-patch-checksum
branch
from
cee9d9e to
1990542
Compare
RDIL
previously approved these changes
Oct 26, 2022
|
It would indeed, I'll make this a draft until I've made one. |
merceyz
force-pushed
the
merceyz/perf/improve-patch-checksum
branch
from
ec3e239 to
331d8ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Whenever the PnP compatibility patch for TypeScript is updated all versions of TypeScript is re-patched even if nothing changed for that version.
Examples of this happening:
How did you fix it?
Compute the hash from the effects of the patch to avoid the hash changing when the effects of the patch hasn't changed.
Checklist