fix: handle unintentional floating promises

[merceyz]

What's the problem this PR addresses?

There are promises in the codebase (mostly in tests) that aren't awaited when they should be.

Hopefully solves the Jest did not exit one second after the test run has completed. from nodejs/citgm#905 (comment).

How did you fix it?

await the promise or change to the sync version if possible.

Checklist

• I have read the Contributing Guide.
• I have set the packages that need to be released for my changes to be effective.
• I will check that all automated PR checks pass before the PR gets reviewed.

[SimenB]

https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-expect.md might be useful 🙂

[merceyz]

@SimenB Probably, in this case I found them with https://typescript-eslint.io/rules/no-floating-promises/ but didn't commit it for now.

[SimenB]

FWIW, the jest rule doesn't require type information (which doesn't really work in monorepos). It won't catch as many cases, but it would catch all the resolves ones at least.