Skip to content

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Nov 8, 2022

What's the problem this PR addresses?

The exec: protocol logs aren't printed even when enableInlineBuilds is defined, which prevents seeing potential errors (especially on CI).

How did you fix it?

The fetcher will now respect enableInlineBuilds. I thought about adding a separate configuration setting, but it felt unnecessary as the reasons why one would want to see the output of the builds also require to show the output of the exec: package generation.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@RDIL RDIL changed the title Adds support for enableInlineBuilds to the exec: fetcher feat(exec)!: Adds support for enableInlineBuilds to the exec: fetcher Nov 8, 2022
@RDIL RDIL added the major label Nov 8, 2022
@arcanis arcanis merged commit 3aac4e8 into master Nov 9, 2022
@arcanis arcanis deleted the mael/exec-fetcher-inline-builds branch November 9, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants