Skip to content

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Nov 13, 2022

What's the problem this PR addresses?

Building @yarnpkg/libzip requires having a specific version of emsdk installed at ~/emsdk, if the version doesn't match we change it and mutate the host.

How did you fix it?

Use Docker to have a consistent environment to build @yarnpkg/libzip and avoid mutating the host.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner November 13, 2022 15:01
@arcanis arcanis merged commit 0bb0494 into master Nov 18, 2022
@arcanis arcanis deleted the merceyz/build/libzip-docker branch November 18, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants