Implements automated constraints checks #5204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
commented
Jan 18, 2023
Comment on lines
+1533
to
+1534
| if (hasErrors) | ||
| return; |
There was a problem hiding this comment.
I marked the PR as breaking change for @yarnpkg/cli, because the validation errors didn't previously stop the execution. However, if they don't, there's a decent risk it'll hide important information due to peer dependency warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Running constraints must currently be a conscious thing, or run on CI. I think some users have the expectation that Yarn should just report the errors during install, as it's the main interface they'll use.
How did you fix it?
This PR adds a new setting,
enableConstraintsChecks. When enabled, constraints will be checked during each install, as part of the project validation.note: Prolog constraints are slower than the (new) JS ones; it's suggested to upgrade to JS constraints when using this setting.
Checklist