Skip to content

Conversation

shilman
Copy link
Contributor

@shilman shilman commented Feb 13, 2023

Yarn CI runs are registering in our telemetry data, so it would be great to filter those out at the source! 🙏

@shilman shilman requested a review from arcanis as a code owner February 13, 2023 03:10
@merceyz
Copy link
Member

merceyz commented Feb 13, 2023

I'm fine with adding this but would like to mention that the e2e test for Storybook has been disabled since 2023-01-11 since it had been failing since 2022-10-05.

I tested it again now and it still fails with

ERR! Error: @storybook/core-common tried to access @storybook/react-webpack5, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
ERR!
ERR! Required package: @storybook/react-webpack5 (via "@storybook/react-webpack5/preset")
ERR! Required by: @storybook/core-common@npm:7.0.0-beta.46 (via /root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/)
ERR!
ERR! Require stack:
ERR! - /root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js
ERR! - /root/.yarn/berry/cache/@storybook-telemetry-npm-7.0.0-beta.46-2b325735d0-8.zip/node_modules/@storybook/telemetry/dist/index.js
ERR! - /root/.yarn/berry/cache/@storybook-cli-npm-7.0.0-beta.46-aec8906c78-8.zip/node_modules/@storybook/cli/dist/generate.js
ERR! - /root/.yarn/berry/cache/@storybook-cli-npm-7.0.0-beta.46-aec8906c78-8.zip/node_modules/@storybook/cli/bin/index.js
ERR! - /root/.yarn/berry/cache/storybook-npm-7.0.0-beta.46-3d9afedaf1-8.zip/node_modules/storybook/index.js
ERR!     at require$$0.Module._resolveFilename (/app/my-cra/.pnp.cjs:30683:13)
ERR!     at require$$0.Module._load (/app/my-cra/.pnp.cjs:30533:42)
ERR!     at Module.require (node:internal/modules/cjs/loader:1105:19)
ERR!     at require (node:internal/modules/cjs/helpers:103:18)
ERR!     at interopRequireDefault (/root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js:6:21)
ERR!     at getContent (/root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js:13:332)
ERR!     at loadPreset (/root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js:13:517)
ERR!     at /root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js:15:411
ERR!     at Array.map (<anonymous>)
ERR!     at loadPresets (/root/.yarn/berry/cache/@storybook-core-common-npm-7.0.0-beta.46-d4343da031-8.zip/node_modules/@storybook/core-common/dist/index.js:15:393)
ERR!  Error: @storybook/core-common tried to access @storybook/react-webpack5, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Tested using:

cd $(mktemp -d)
corepack [email protected] dlx create-react-app my-cra && cd my-cra
corepack [email protected] config set pnpFallbackMode none
corepack [email protected] add -D eslint-config-react-app eslint
corepack [email protected] dlx -p @storybook/cli@next sb init --yes
corepack [email protected] build-storybook

@merceyz merceyz changed the title Disable storybook telemetry ci(e2e): disable storybook telemetry Oct 18, 2023
@merceyz merceyz enabled auto-merge October 18, 2023 21:13
@merceyz merceyz added this pull request to the merge queue Oct 19, 2023
Merged via the queue into yarnpkg:master with commit c751963 Oct 19, 2023
merceyz added a commit that referenced this pull request Oct 21, 2023
Yarn CI runs are registering in our telemetry data, so it would be great
to filter those out at the source! 🙏

Co-authored-by: Kristoffer K <[email protected]>
(cherry picked from commit c751963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants