fix(fslib): export CustomDir
#5371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-one
force-pushed
the
export-custom-dir
branch
from
7519a8a to
88f1de7
Compare
RDIL
requested changes
Apr 6, 2023
bruce-one
force-pushed
the
export-custom-dir
branch
from
88f1de7 to
d2247de
Compare
To allow compatible implementations of `opendir` to be created by consumers of this library.
bruce-one
force-pushed
the
export-custom-dir
branch
from
d2247de to
e0fea10
Compare
bruce-one
added a commit
to bruce-one/nexe
that referenced
this pull request
Apr 7, 2023
Will squash after yarnpkg/berry#5371 lands.
merceyz
approved these changes
Apr 7, 2023
bruce-one
added a commit
to bruce-one/nexe
that referenced
this pull request
Apr 8, 2023
Will squash after yarnpkg/berry#5371 lands.
RDIL
approved these changes
Apr 8, 2023
bruce-one
added a commit
to bruce-one/nexe
that referenced
this pull request
Apr 8, 2023
Will squash after yarnpkg/berry#5371 lands.
bruce-one
added a commit
to bruce-one/nexe
that referenced
this pull request
Apr 8, 2023
Will squash after yarnpkg/berry#5371 lands.
bruce-one
added a commit
to bruce-one/nexe
that referenced
this pull request
Apr 8, 2023
Will squash after yarnpkg/berry#5371 lands.
|
For whatever reason the deploy preview for the website is failing so we can't merge it due to the permission setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I'm in the process of upgrading an application (nexe) leveraging
@yarnpkg/fslibfrom 2.x to 3.x.In version 2 we were able to import
CustomDirto create a custom implementation ofopendirthat was usable with aFakeFS, however this is no longer exported so doing so is no longer possible to leverage theCustomDirclass....
How did you fix it?
This PR exports
CustomDirin addition toopendirfromopendir.ts....
Checklist