Followups on the release branch workflow #5478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
approved these changes
Jun 3, 2023
merceyz
pushed a commit
that referenced
this pull request
Jun 3, 2023
- The GH action doesn't fetch the `master` branch, so it was missing - The job wasn't retry-able, the npm package publishing would have failed.
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Jun 7, 2023
…ses (#5482) **What's the problem this PR addresses?** - Release is stopped when `scripts/release/01-release-tags.sh` has no work to do. - `scripts/release/02-release-builds.sh` assumes `HEAD` is the release commit but it might not be, for example after committing fixes to the release workflow and creating a new release. - The release commit isn't getting pushed to `master`. Follow-up to #5476 and #5478. **How did you fix it?** - Handle no new packages to release and change the exit code to 0. - Find the last release commit and check that instead of `HEAD`. - Reset the changes done to `.yarnrc.yml` and push the changes. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
Jun 7, 2023
…ses (#5482) **What's the problem this PR addresses?** - Release is stopped when `scripts/release/01-release-tags.sh` has no work to do. - `scripts/release/02-release-builds.sh` assumes `HEAD` is the release commit but it might not be, for example after committing fixes to the release workflow and creating a new release. - The release commit isn't getting pushed to `master`. Follow-up to #5476 and #5478. **How did you fix it?** - Handle no new packages to release and change the exit code to 0. - Find the last release commit and check that instead of `HEAD`. - Reset the changes done to `.yarnrc.yml` and push the changes. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
arcanis
pushed a commit
to yarnpkg/example-repo-zipn
that referenced
this pull request
Jul 3, 2023
…ses (#5482) **What's the problem this PR addresses?** - Release is stopped when `scripts/release/01-release-tags.sh` has no work to do. - `scripts/release/02-release-builds.sh` assumes `HEAD` is the release commit but it might not be, for example after committing fixes to the release workflow and creating a new release. - The release commit isn't getting pushed to `master`. Follow-up to yarnpkg/berry#5476 and yarnpkg/berry#5478. **How did you fix it?** - Handle no new packages to release and change the exit code to 0. - Find the last release commit and check that instead of `HEAD`. - Reset the changes done to `.yarnrc.yml` and push the changes. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Squirt9
reviewed
Aug 9, 2023
| @@ -59,6 +59,7 @@ jobs: | |||
| run: | | |||
| RELEASE_COMMIT=$(git rev-parse HEAD) | |||
| node ./scripts/stable-versions-store.js | |||
| git fetch origin master | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch, so it was missing