Skip to content

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

After some discussions, we've agreed on changing motd to tips, as the motd acronym (message of the day) might not be widespread enough.

How did you fix it?

This PR changes:

  • enableMotd to enableTips
  • the MOTD_NOTICE message name to TIPS_NOTICE
  • motd.json to tips.json (CC @arcanis since you need to change the cloudflare worker)
  • TelemetryManager#isMotd to TelemetryManager#shouldShowTips as it's more descriptive and also more consistent with the existing shouldCommitTips

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 915aa15 into master Jul 3, 2023
@arcanis arcanis deleted the paul/refactor/motd-to-tips branch July 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants