refactor: rename motd
to tips
#5561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
After some discussions, we've agreed on changing
motd
totips
, as themotd
acronym (message of the day
) might not be widespread enough.How did you fix it?
This PR changes:
enableMotd
toenableTips
MOTD_NOTICE
message name toTIPS_NOTICE
motd.json
totips.json
(CC @arcanis since you need to change the cloudflare worker)TelemetryManager#isMotd
toTelemetryManager#shouldShowTips
as it's more descriptive and also more consistent with the existingshouldCommitTips
Checklist