perf: remove unnecessary realpath on --cwd
#5603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-soporan
commented
Jul 28, 2023
packages/yarnpkg-cli/sources/lib.ts
Outdated
| } else if (argv.length >= 1 && argv[0].startsWith(`--cwd=`)) { | ||
| cwd = npath.toPortablePath(argv[0].slice(6)); | ||
| postCwdArgv = argv.slice(1); | ||
| } | ||
|
|
||
| cli.defaultContext.cwd = cwd ?? ppath.cwd(); |
There was a problem hiding this comment.
You removed the resolve calls, which are important because everything breaks if this.context.cwd isn't an absolute path.
Suggested change
| cli.defaultContext.cwd = cwd ?? ppath.cwd(); | |
| cli.defaultContext.cwd = ppath.resolve(cwd) ?? ppath.cwd(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
--cwdargument is currently resolved usingrealpathSync.This behavior was introduced in #373 as a workaround for a bug caused by symlinks and the recursive
--cwdlogic.How did you fix it?
Removed the unnecessary
realpathcalls. They are no longer needed due to the removal of the recursive logic in #5600.I've also added a few tests, I'll add the rest from #5595 in a future PR.
Checklist