Skip to content

test: use stream.promises.pipeline #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

test: use stream.promises.pipeline #5611

merged 1 commit into from
Jul 25, 2023

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

Our tests still use promisify(stream.pipeline).

How did you fix it?

Made them use stream.promises.pipeline, which has been available since Node 15.0.0.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 60a3c49 Jul 25, 2023
@paul-soporan paul-soporan deleted the paul/test/pipeline branch July 25, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-soporan @merceyz