refactor!: simplify Configuration.findProjectCwd
#5627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Configuration.findProjectCwdis written to support both alockfilelookup (which is kind of a mixed lookup anyways) and amanifestlookup.Configuration.findsupports both these lookups and alsoProjectLookup.NONE, which only looks inside the current folder.ProjectLookup.MANIFESTisn't used anywhere, andProjectLookup.NONEis only used inside@yarnpkg/doctor, but it should never get to run becausefindLockfileWorkspaceruns first and it does a regular mixed lookup which already succeeds even if there's no lockfile but there's a manifest.How did you fix it?
I simplified all of this and got rid of the lookups. Now everything does a mixed ("lockfile") lookup by default.
Checklist