Fixes bugs in yarn npm audit #5833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The rewrite of
yarn npm audit
broke a couple of things in the advisory reporting.Fixes #5824 - The
--exclude
filter wasn't applied to deprecationsFixes #5830 - The
--json
output was printing the raw registry output, not the filtered treeHow did you fix it?
Fixed the deprecation iterations (we were iterating the unfiltered data).
Fixed the json reporting to instead print the same tree as the one we would have displayed outside of
--json
. It's technically a breaking change, but it was supposed to be like that so it's probably fine to treat it as a 7.0.1 bugfix.Added tests to prevent regressions.
Checklist