Reverts the INIT_CWD change #5930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
commented
Nov 3, 2023
| case `pnpm`: { | ||
| return {packageManagerField: true, packageManager: PackageManager.Pnpm, reason}; | ||
| } break; |
There was a problem hiding this comment.
I'm not sure why, but my IDE constantly removes those statements by itself. It's technically correct, but really annoying to have those unrelated changes every time I update the file.
There was a problem hiding this comment.
A global eslint config or a different extension perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The changes in #4817 caused some breakages in how our users had setup their scripts. While it can be argued that the current behaviour is better by some measures, I'd prefer to avoid breaking anything, especially since it's not very well documented (and/or understood) what's the semantic of INIT_CWD when used with
yarn workspace,yarn workspaces foreach, and global scripts.Fixes #5750
How did you fix it?
I reverted #4817. I'll do a separate semver-minor PR to add extra environment variables with better semantic than INIT_CWD, but that will be in a second time.
Checklist