Cleanups some tests #6388
Merged
Cleanups some tests #6388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I'm reviewing our tests and came upon some of them that could be dumbed down. I prefer to make them test as little things as possible to avoid something breaking due to unrelated parts of the code changing (I'm working on switching some implementations, and limiting test dependencies make things considerably easier / more fun to work on).
How did you fix it?
No big changes - it's mostly things like using the
dependenciesrather than callingyarn addand avoiding to rely on cache paths to check whether something got properly installed.Checklist