ci: migrate e2e to eslint v9 flat config #6699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The workflow .github/workflows/e2e-eslint-workflow.yml fails with
It was last successful 11 months ago on Apr 5, 2024 coinciding with the release of ESLint 9.0.0 which changed the default config to flat.
The workflow installs
eslint
with no version specified, thereforeeslint@latest
is used (currently[email protected]
).How did you fix it?
In the workflow .github/workflows/e2e-eslint-workflow.yml
each
.estlintrc
is changed toeslint.config.mjs
Validating ESLint
The ESLint rule semi was deprecated in ESLint v8.53.0 and moved instead to @stylistic/eslint-plugin-js.
Following the ESLint Stylistic Migration Guide and using the recommended approach of one single plugin, additionally install @stylistic/eslint-plugin.
Use the rule @stylistic/semi.
Running the TypeScript integration test
typescript-eslint v7 allows switching from @typescript-eslint/parser and @typescript-eslint/eslint-plugin to typescript-eslint.
Checklist