Fix Resolve the issue of Replication bootstrap using schemaDatabase for JDBC connection #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
too many whitespace changes, please turn off your editor auto-formatting. |
osheroff
reviewed
Jan 9, 2025
| return uriBuilder.build().toString(); | ||
| } | ||
|
|
||
| private String getConfigtReplicationConnectionURI(MaxwellMysqlConfig config) throws URISyntaxException { |
There was a problem hiding this comment.
little typo here, extra t
There was a problem hiding this comment.
Sorry, this is the first time in my life I've committed to an open source repository and I'm a little nervous
I'm sorry, I've already taken care of it |
|
have you tested this locally to make sure it works? If so I'm happy to merge it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the issue of Replication bootstrap using schemaDatabase for JDBC connection