Skip to content

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Apr 23, 2025

No description provided.

@agolovan agolovan mentioned this pull request Apr 24, 2025
@StefH StefH requested a review from Copilot April 24, 2025 09:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DynamicGetMemberBinder to add BindingRestrictions addressing issues #907 and #912, while also renaming test attributes and expanding test coverage for dynamic member binding.

  • Updates DynamicGetMemberBinder to include BindingRestrictions in the fallback binding logic.
  • Renames the test attribute from SkipIfGitHubActions to SkipIfGitHubActionsFact and adds new tests covering dynamic selection over arrays and DataTables.
  • Enhances expression promotion logic in ExpressionParser and updates sample demo programs to reflect these changes.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/System.Linq.Dynamic.Core.Tests/TestHelpers/SkipIfGitHubActionsFactAttribute.cs Renamed the attribute and constructor to improve clarity.
test/System.Linq.Dynamic.Core.Tests/EntitiesTests.Select.cs Added a new test (Entities_Select_DynamicClass_And_Select_DynamicClass) to verify dynamic class selection.
test/System.Linq.Dynamic.Core.Tests/DynamicGetMemberBinderTests.cs Introduced multiple tests for dynamic member binding on arrays and DataTables.
test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs Updated attribute usages for consistency with the renaming.
src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs Modified promotion logic to fall back on Expression.Convert when needed.
src/System.Linq.Dynamic.Core/DynamicGetMemberBinder.cs Updated FallbackGetMember to include BindingRestrictions, fixing issues #907 and #912.
src-console/ConsoleApp_net6.0/Program.cs Updated method names and added dynamic binding examples.
src-console/ConsoleAppEF6_InMemory/Program.cs Added additional dynamic binding scenarios within an EF6 in-memory context.
Files not reviewed (1)
  • test/EntityFramework.DynamicLinq.Tests/EntityFramework.DynamicLinq.Tests.csproj: Language not supported
Comments suppressed due to low confidence (1)

src-console/ConsoleApp_net6.0/Program.cs:131

  • [nitpick] The variable 'x' appears to be a leftover from debugging; consider removing it if it is not used in production code.
int x = 9;

@StefH StefH merged commit 64b5eff into master Apr 24, 2025
3 of 4 checks passed
@StefH StefH deleted the DynamicGetMemberBinder branch April 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant