0007028: Apply transforms to oldValue to help remote system find the record to update or delete #342
Conversation
pavel-jm
requested review from
erilong,
philipmarzullo64,
catherinequamme and
awebbdev1
| result.setNewValue(expression); | ||
| } | ||
| if (StringUtils.isBlank(oldValue)) { | ||
| result.setOldValue(expression); |
There was a problem hiding this comment.
By default, the data loader only loads columns that are changing (dataloader.apply.changes.only=true), so by setting the old and new values to the same value, the column will be ignored. The introduction of NewAndOldValue was supposed to be backwards compatible, which is why only newer transforms are using it.
There was a problem hiding this comment.
I agree with compatibility, but differ on one point:
The only way Old value and New value are the same if
StringUtils.isBlank(newValue) == StringUtils.isBlank(oldValue)
Otherwise values will be different and this is an improvement over existing code, which sends OldValue of NULL (bypassing this transform) to the system, which cannot accept NULLs due to table structure being different from the source database.
Do NOT approve PR just yet - more changes are coming!