Skip to content

0007028: Apply transforms to oldValue to help remote system find the record to update or delete #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+27 −17
Closed

0007028: Apply transforms to oldValue to help remote system find the record to update or delete #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8047d8
Apply IsBlankTransform to the oldValue to help remote system find the
pavel-jm Aug 21, 2025
7cd2e66
Cut logging in IsBlankTransform
pavel-jm Aug 21, 2025
cb25377
Refactor IsBlankTransform.transformValue
pavel-jm Aug 22, 2025
10327c2
Add transformation of the oldValue to IsEmptyTransform
pavel-jm Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/transform/IsBlankTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@ public String getName() {
return NAME;
}

@Override
public boolean isExtractColumnTransform() {
return true;
}

@Override
public boolean isLoadColumnTransform() {
return true;
}
Expand All @@ -49,14 +51,17 @@ public boolean isLoadColumnTransform() {
public NewAndOldValue transform(IDatabasePlatform platform, DataContext context, TransformColumn column,
TransformedData data, Map<String, String> sourceValues, String newValue, String oldValue)
throws IgnoreColumnException, IgnoreRowException {
NewAndOldValue result = new NewAndOldValue(newValue, oldValue);
if (StringUtils.isBlank(newValue)) {
String expression = column.getTransformExpression();
if (StringUtils.isEmpty(expression)) {
expression = null;
}
result = new NewAndOldValue(expression, oldValue);
return new NewAndOldValue(transformValue(column, newValue), transformValue(column, oldValue));
}

private String transformValue(TransformColumn column, String sourceValue) {
String expression = column.getTransformExpression();
if (StringUtils.isEmpty(expression)) {
expression = null;
}
if (StringUtils.isBlank(sourceValue)) {
return expression;
}
return result;
return sourceValue;
}
}
23 changes: 14 additions & 9 deletions symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/transform/IsEmptyTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@ public String getName() {
return NAME;
}

@Override
public boolean isExtractColumnTransform() {
return true;
}

@Override
public boolean isLoadColumnTransform() {
return true;
}
Expand All @@ -49,14 +51,17 @@ public boolean isLoadColumnTransform() {
public NewAndOldValue transform(IDatabasePlatform platform, DataContext context, TransformColumn column,
TransformedData data, Map<String, String> sourceValues, String newValue, String oldValue)
throws IgnoreColumnException, IgnoreRowException {
NewAndOldValue result = new NewAndOldValue(newValue, oldValue);
if (StringUtils.isEmpty(newValue)) {
String expression = column.getTransformExpression();
if (StringUtils.isEmpty(expression)) {
expression = null;
}
result = new NewAndOldValue(expression, oldValue);
return new NewAndOldValue(transformValue(column, newValue), transformValue(column, oldValue));
}

private String transformValue(TransformColumn column, String sourceValue) {
String expression = column.getTransformExpression();
if (StringUtils.isEmpty(expression)) {
expression = null;
}
if (StringUtils.isEmpty(sourceValue)) {
return expression;
}
return result;
return sourceValue;
}
}
}